Skip to content

Conversation

@shoumikhin
Copy link
Contributor

No description provided.

@shoumikhin shoumikhin requested a review from kirklandsign as a code owner June 30, 2025 18:30
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12115

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated Failure

As of commit 350794f with merge base 29858b4 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 30, 2025
@shoumikhin shoumikhin added the release notes: none Do not include this in the release notes label Jun 30, 2025
@shoumikhin shoumikhin requested a review from larryliu0820 June 30, 2025 18:42
@mergennachin
Copy link
Contributor

Why is this not 0.8.nightly instead?

@mergennachin mergennachin self-requested a review June 30, 2025 19:15
Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swiftpm-0.8.0-nightly for main branch
swiftpm-0.7.0 for release/0.7 branch

@shoumikhin
Copy link
Contributor Author

shoumikhin commented Jun 30, 2025

@mergennachin iirc you wanted the demo apps to be pinned to a stable version? This PR is gonna be cherry-picked, and I can upgrade these projects on the main tomorrow, when the nightly with the new 0.8 is ready.

@mergennachin
Copy link
Contributor

mergennachin commented Jun 30, 2025

iirc you wanted the demo apps to be pinned to a stable version?

Ah yes, I remember that. But that was in the context of https://github.com/pytorch-labs/executorch-examples

In this executorch-examples, we just have main to be pinned against the latest stable release, and there's no complication around which branch etc. People can download the repo and see how the repo should be used in the majority of the case using stable.

For the executorch repo, we already have main and release branch, so it would be good where main is nightly and release is stable, so that we can develop new features progressively.

@shoumikhin shoumikhin requested a review from mergennachin July 3, 2025 05:38
@mergennachin
Copy link
Contributor

And make sure to have swiftpm-0.7.0 for release/0.7 branch too

@shoumikhin shoumikhin merged commit 6da7bde into main Jul 3, 2025
106 of 109 checks passed
@shoumikhin shoumikhin deleted the shoumikhin-patch-1 branch July 3, 2025 20:07
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants